ORCA: Validate hash function existence in IsOpHashJoinable#1519
Merged
yjhjstz merged 1 commit intoapache:mainfrom Jan 13, 2026
Merged
ORCA: Validate hash function existence in IsOpHashJoinable#1519yjhjstz merged 1 commit intoapache:mainfrom
yjhjstz merged 1 commit intoapache:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in ORCA where operators marked with oprcanhash=true but lacking actual hash support functions would cause runtime errors during query execution. The fix moves error detection from execution time to planning time by adding validation in IsOpHashJoinable().
Key Changes:
- Added hash function existence validation using
get_op_hash_functions()inIsOpHashJoinable() - Comprehensive regression test demonstrating the fix
- Test creates operators with the
hashesflag but without valid hash operator families
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/backend/gpopt/gpdbwrappers.cpp | Enhanced IsOpHashJoinable() to validate hash function existence before allowing hash-based operations |
| src/test/regress/sql/gp_hashagg.sql | Added regression test creating custom type with operators marked hashable but lacking hash functions |
| src/test/regress/expected/gp_hashagg.out | Expected output showing queries succeed with the fix instead of failing at execution time |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tuhaihe
force-pushed
the
fix_orca_hashagg
branch
from
0db256d to
8227aa8
Compare
Fix execution-time error when operators have oprcanhash=true but lack actual hash functions. Previously, ORCA would generate HashAgg plans that failed at runtime with "could not find hash function for hash operator" errors. This occurred when operators were marked with the 'hashes' option but only registered in btree operator families, not hash operator families. The fix adds validation using get_op_hash_functions() to ensure hash functions exist before allowing HashAgg plans, moving error detection from execution to planning time.
yjhjstz
force-pushed
the
fix_orca_hashagg
branch
from
8227aa8 to
d0a2bcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix execution-time error when operators have oprcanhash=true but lack actual hash functions. Previously, ORCA would generate HashAgg plans that failed at runtime with "could not find hash function for hash operator" errors.
This occurred when operators were marked with the 'hashes' option but only registered in btree operator families, not hash operator families. The fix adds validation using get_op_hash_functions() to ensure hash functions exist before allowing HashAgg plans, moving error detection from execution to planning time.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions